Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit posts list length to 50 posts #106

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Limit posts list length to 50 posts #106

merged 1 commit into from
Mar 18, 2023

Conversation

tnix100
Copy link
Member

@tnix100 tnix100 commented Mar 13, 2023 •
edited
Loading

Do this so the client doesn't get slower if there's heaps of posts made.

williamhorning
williamhorning approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@williamhorning williamhorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you might want to increase this limit or have an option to turn it off on the settings page

@PizzaPizza72
Copy link

Should I merge this PR? Just checking to see if anyone is OK with it before I do.

@showierdata9978
Copy link
Member

Should I merge this PR? Just checking to see if anyone is OK with it before I do.

Not all the approvals are met yet, exp not the most important one from @CST1229

@williamhorning williamhorning merged commit 5fb0fa3 into master Mar 18, 2023
@williamhorning williamhorning deleted the tnix-limit-posts-list branch March 18, 2023 17:40
@williamhorning williamhorning mentioned this pull request Mar 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeDev101 MikeDev101 MikeDev101 approved these changes

@showierdata9978 showierdata9978 showierdata9978 approved these changes

@CST1229 CST1229 CST1229 approved these changes

@williamhorning williamhorning williamhorning approved these changes

@JoshAtticus JoshAtticus JoshAtticus approved these changes

@ArrowAced ArrowAced Awaiting requested review from ArrowAced

@Bloctans Bloctans Awaiting requested review from Bloctans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tnix100 @PizzaPizza72 @showierdata9978 @MikeDev101 @CST1229 @williamhorning @JoshAtticus